Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile releases #3002

Merged
merged 16 commits into from
Sep 30, 2019
Merged

Mobile releases #3002

merged 16 commits into from
Sep 30, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Sep 30, 2019

Closes #ISSUE

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb requested review from colw and jbibla as code owners September 30, 2019 14:58
@jbibla
Copy link
Collaborator

jbibla commented Sep 30, 2019 •
edited
Loading

looks good to me.

we have all the icons and images needed - should we include them in this PR?

@faboweb faboweb merged commit 8e495f4 into develop Sep 30, 2019
@faboweb
Copy link
Collaborator Author

faboweb commented Sep 30, 2019

we have all the icons and images needed - should we include them in this PR?

I would recommend another PR. There are release scripts in package.json now

@faboweb faboweb mentioned this pull request Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbibla jbibla jbibla approved these changes

@colw colw Awaiting requested review from colw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @jbibla