clicking a balance will go to the send page with that denom selected... #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… balance page displays balances and denominations on the network as separate lists
faboweb
reviewed
Jan 2, 2018
| @@ -68,7 +68,7 @@ export default [ | |||
|
|
|||
| // WALLET | |||
| { path: '/', name: 'balances', component: wallet('Balances') }, | |||
| { path: '/wallet/send', name: 'send', component: wallet('Send') }, | |||
| { path: '/wallet/send', name: 'send', props: true, component: wallet('Send') }, | |||
faboweb
reviewed
Jan 2, 2018
| @@ -8,7 +8,7 @@ page(title='Send') | |||
| field-id='send-denomination' field-label='Denomination') | |||
| field#send-denomination( | |||
| type="select" | |||
| v-model="fields.denom" | |||
| v-model="fields.denom || denom" | |||
There was a problem hiding this comment.
I am not sure if this works properly. This will set the model to use the property "denom". onSubmit uses "fields.denom". Is it tested, that this works? I proposed another way to set the denom.
faboweb
reviewed
Jan 2, 2018
| mounted () { | ||
| if (this.denominations.length === 1) { | ||
| this.fields.denom = this.denominations[0].value | ||
| if (this.denom) { |
There was a problem hiding this comment.
I set the denom from the property here. So the variable "fields.denom" stays the one truth for the currently selected denom.
There was a problem hiding this comment.
i think this is better. thanks for the improvement.
faboweb
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... balance page displays balances and denominations on the network as separate lists
part of #128