Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peng/282 fix mobile #287

Merged
merged 4 commits into from
Dec 29, 2017
Merged

Peng/282 fix mobile #287

merged 4 commits into from
Dec 29, 2017

Conversation

nylira
Copy link
Contributor

@nylira nylira commented Dec 29, 2017 •
edited
Loading

  • fixes an issue where resizing the app window to < 1024px broke page scrolling
  • fixed an issue where the app footer overlapped the page content on screens of < 567px
  • fixed an issue where the network connectivity wasn't showing on mobile
  • removed the 567px media query breakpoint for showing NiToolBar at the bottom of the screen in favor of the 1024px breakpoint (which is standard across the app)
  • created a NiConnectivity module to show network status for desktop and mobile
  • NiConnectivity on mobile is now shown at the bottom of the AppMenu
  • added tests for NiConnectivity

Previews

screen shot 2017-12-29 at 1 46 08 pm

screen shot 2017-12-29 at 2 27 29 pm

Closes #282

@nylira nylira requested a review from mappum as a code owner December 29, 2017 05:32
@faboweb faboweb merged commit e18325e into develop Dec 29, 2017
@faboweb faboweb deleted the peng/282-fix-mobile branch December 29, 2017 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@mappum mappum Awaiting requested review from mappum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

footer broken on small screen
2 participants
@nylira @faboweb