refactor li proposal test #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faboweb
reviewed
Feb 25, 2019
sabau
reviewed
Feb 26, 2019
sabau
reviewed
Feb 26, 2019
sabau
previously requested changes
Feb 26, 2019
fedekunze
reviewed
Feb 26, 2019
Codecov Report
@@ Coverage Diff @@
## develop #2074 +/- ##
=======================================
Coverage 95.4% 95.4%
=======================================
Files 110 110
Lines 2570 2570
Branches 103 103
=======================================
Hits 2452 2452
Misses 109 109
Partials 9 9
|
Codecov Report
@@ Coverage Diff @@
## develop #2074 +/- ##
========================================
Coverage 95.31% 95.31%
========================================
Files 110 110
Lines 2581 2581
Branches 104 104
========================================
Hits 2460 2460
Misses 112 112
Partials 9 9
|
sabau
dismissed
their stale review
Maybe we can fix the duplicated code separately, so we can clean up the PR queue :)
fedekunze
reviewed
Feb 27, 2019
CHANGELOG.md
Outdated
| @@ -47,6 +51,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Refactored tests: PageStaking, PanelSort, TabStakingParameters @faboweb | |||
|
|
|||
| ## Fixed | |||
fedekunze
reviewed
Feb 27, 2019
| @@ -31,16 +31,16 @@ | |||
| </td> | |||
| <td>{{ `#` + proposal.proposal_id }}</td> | |||
| <td class="li-proposal__value yes"> | |||
| {{ tally.yes }} | |||
| {{ tally.yes || `--` }} | |||
There was a problem hiding this comment.
side note: we should maybe prettify the tally result numbers
There was a problem hiding this comment.
what do you mean by prettify?
There was a problem hiding this comment.
there is a function called pretty which shortens the value after 4 decimals
faboweb
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For contributor:
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: