Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve transaction pages #168

Merged
merged 8 commits into from
Dec 5, 2017
Merged

Improve transaction pages #168

merged 8 commits into from
Dec 5, 2017

Conversation

nylira
Copy link
Contributor

@nylira nylira commented Dec 5, 2017 •
edited
Loading

  • redesigned CardTransaction and renamed it to LiTransaction. Reasoning: Cards can be laid out in a 2D grid, while ListItems are laid out in one dimension only
  • the new LiTransaction layout works for small and large screens
  • the new layout supports one to infinite coins per transaction
  • there is a hover effect that links to the TODO: transaction view page
  • updated the transaction colors to match the site (@jolesbi should we use these colors or danger and success? I was thinking to relegatedanger and success only to error/achievment states, but it is also common to show incoming transactions in green and outgoing in red)
  • updated the associated test

Old Design (with multiple coins)

screen shot 2017-12-05 at 2 22 20 pm

New Design (with multiple coins)

screen shot 2017-12-05 at 1 51 21 pm

Fixes #148

@nylira nylira requested a review from mappum as a code owner December 5, 2017 05:12
@faboweb
Copy link
Collaborator

faboweb commented Dec 5, 2017

I like the structure I like the added Icons!
I feel the separation between transactions is not so visible. Also the contrast for the positive values in comparison to the background feels to less.
One idea: What about putting the icons on the first row always? Having them centered feels chaotic.

I feel not strong about any of this and we could also first merge and adjust later.

faboweb
faboweb approved these changes Dec 5, 2017
View reviewed changes
app/src/renderer/components/wallet/LiTransaction.vue
}),
methods: {
viewTransaction () {
this.$store.commit('notify', {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nylira
Copy link
Contributor Author

nylira commented Dec 5, 2017

@faboweb I like your suggestions, and have thought about those issues too. Let's do it in the future. Merging this.

@nylira nylira merged commit 528340a into develop Dec 5, 2017
@faboweb faboweb deleted the peng/148-improve-tx-view branch December 5, 2017 17:51
faboweb added a commit that referenced this pull request Jun 2, 2020
@faboweb
[Simsala] automatic release created for v1.0.16 (#168)
4c47a14 
* always use cheap source maps

* remove e2e tests for now

* changelog

* release-1.0.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@mappum mappum Awaiting requested review from mappum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nylira @faboweb