WIP: Update validators when they change #1083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 2, 2018 11:37
…kunze/1010-lcd-stake pull
…kunze/946-updateValidators
|
24 days old?
|
|
As discussed in the team meeting this is waiting for a new Tendermint version to be merged into the SDK. |
|
Haha OMG @jbibla you crack me up! |
|
can we close this or are we waiting for new tendermint version? i smell a lot of conflicts on the horizon 👃 |
|
@jbibla you're right. Although we already have this logic by manually checking the validator set changes on each block. I'd vote to close it and do a later refactor by introducing an observer/subscribe design pattern. |
|
sounds good. @faboweb what do you think? |
|
There are no conflicts as of right now. I don't get what changed since we decided to keep this PR. But if you want to redo the work, feel free to close this. |
|
So @fedekunze, shall we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #946
Description:
Subscribes to new tendermint event
tm.event='ValidatorSetUpdates'.Blocked by tendermint/2161, which is blocked by tendermint/2159.
❤️ Thank you!