Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Delegators View Update #79

Closed
faboweb opened this issue Nov 21, 2017 · 4 comments
Closed

Remove Delegators View Update #79

faboweb opened this issue Nov 21, 2017 · 4 comments

Comments

@faboweb
Copy link
Collaborator

faboweb commented Nov 21, 2017

Child of: #24

Do we still need a filter for on-/offline delegators?
@mappum
Copy link
Contributor

mappum commented Nov 21, 2017

IMO we don't need the Delegators view, it would just end up being a list of thousands of pseudonymous accounts. It won't really be meaningful since there will be so many delegators, similar to making a view of every account balance for the whole chain.

@faboweb
Copy link
Collaborator Author

faboweb commented Nov 21, 2017

Then let's remove it. What do you think @nylira @jolesbi ?

@nylira
Copy link
Contributor

nylira commented Nov 21, 2017

Let's remove it.

@faboweb faboweb changed the title Delegators View Update Remove Delegators View Update Nov 21, 2017
@nylira
Copy link
Contributor

nylira commented Nov 21, 2017

I'll work on this right now.

@nylira nylira self-assigned this Nov 21, 2017
@mappum mappum closed this as completed in ae09fc9 Nov 21, 2017
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Merge pull request #79 from luniehq/Benji/78-E2E-Approve/Reject
2afc897 
Benji/78 E2E Approve/Reject Delegation Transaction
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Fabo/sentry additions (#79)
35d99b6 
* add Sentry context height

* catch and enrich failing transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nylira @mappum @faboweb