Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Accounts #23

Closed
1 of 6 tasks
faboweb opened this issue Oct 30, 2017 · 13 comments
Closed
1 of 6 tasks

Multiple Accounts #23

faboweb opened this issue Oct 30, 2017 · 13 comments

Comments

@faboweb
Copy link
Collaborator

faboweb commented Oct 30, 2017

As a user
I want to be able to add multiple accounts to the wallet
so that I can be more anonymous.

AC:

  • User is able to create another account
  • User is able to select an account for global use
    • User is able to select an account for viewing balances
    • User is able to select an account for viewing transactions
    • User is able to pick an account for public communication (forum)
    • User is able to pick an account for nomination/delegation

Note:

  • Are users able to remove an account?
  • Should the selected account be prominently viewable at all times?
@faboweb
Copy link
Collaborator Author

faboweb commented Nov 2, 2017

Peng:
Perhaps this is a terminology issue we need to fix. The current UI is not going to have multiple accounts. Just one account with multiple coins.

@faboweb
Copy link
Collaborator Author

faboweb commented Nov 2, 2017

Peng:
In the case we want to support multiple accounts, we would need to integrate the basecli keys new mykey command. @mappum would know how to implement this.

@mappum
Copy link
Contributor

mappum commented Nov 2, 2017 via email

@jbibla
Copy link
Collaborator

jbibla commented Nov 2, 2017

since it is possible to have as many accounts as you'd like — i think it would be unfortunate to be stuck with 1 in the GUI — but i think we should flesh out the pros and cons together 🌞 🇲🇽 🌴

@jbibla
Copy link
Collaborator

jbibla commented Nov 7, 2017

from the meeting at Thompson Rooftop

  • user must be able to choose which account to login with
  • true multiple account support in the future

@jbibla jbibla mentioned this issue Nov 28, 2017
@jbibla
Copy link
Collaborator

jbibla commented Nov 29, 2017

I think that this is going to be addressed by forcing the user to use the welcome screen before they access the app.

@faboweb
Copy link
Collaborator Author

faboweb commented Nov 30, 2017

I think the welcome screen only pops up initially right? After that, the user is "signed in".
This one addresses the creation of multiple addresses and being able to check out all of them.

@jbibla
Copy link
Collaborator

jbibla commented Nov 30, 2017

yeah. so the welcome screen lets someone sign in with one address. if they want to sign out and sign back in with another address than that's ok.

is this ticket about a feature where you can be "signed in" with more than one address at a time? does it have something to do with multiple asset types (ATOMS, ETH, BTC, etc...)?

@mappum
Copy link
Contributor

mappum commented Nov 30, 2017

is this ticket about a feature where you can be "signed in" with more than one address at a time? does it have something to do with multiple asset types (ATOMS, ETH, BTC, etc...)?

Doesn't have to be multiple at a time, but at least the ability to switch. It's not about multiple asset types since one account can have multiple denominations. More about cases such as importing an old key from another device, or keeping a cold storage account on your Ledger, etc.

@jbibla
Copy link
Collaborator

jbibla commented Nov 30, 2017

right! cool! so doesn't that mean we can rely on the welcome screen for handling everything to do with multiple accounts? or this feature is about switching between existing accounts very easily from within the app? is that the idea?

@mappum
Copy link
Contributor

mappum commented Nov 30, 2017

Relying on the welcome screen is easy enough for now. This requirement got brought up because the previous solution was to copy private key files around to switch keys, so anything is better than that.

@faboweb faboweb removed the question label Dec 13, 2017
@jbibla jbibla added this to the Launch v1 milestone Jan 22, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Feb 26, 2018

This is done via "sign out" -> "sign in" right?

@jbibla
Copy link
Collaborator

jbibla commented Feb 26, 2018

yep. this is done!! 🎉 🌮

@jbibla jbibla closed this as completed Feb 26, 2018
faboweb added a commit that referenced this issue Jun 2, 2020
Fabo/added unit testing and linting
faboweb pushed a commit that referenced this issue Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants