Merge pull request #3000 from luniehq/mario/2983-moniker-undefined-re…

…delegations Mario/2983 moniker undefined redelegations
luniehq · Sep 30, 2019 · ba8651c · ba8651c
2 parents 598e95e + 78e2168
commit ba8651c
Show file tree

Hide file tree

Showing 5 changed files with 489 additions and 483 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -15,15 +15,15 @@ commands:
     steps:
       - restore_cache:
           keys:
-            - v4-dependencies-root-{{ checksum "package.json" }}
-            - v4-dependencies-root-
+            - v5-dependencies-root-{{ checksum "yarn.lock" }}
+            - v5-dependencies-root-
 
       - run: yarn install
       - save_cache:
           paths:
             - yarn.lock
             - node_modules
-          key: v4-dependencies-root-{{ checksum "package.json" }}
+          key: v5-dependencies-root-{{ checksum "yarn.lock" }}
 
   yarn-install-extension:
     description: "[YARN] update and install"

diff --git a/changes/mario_2983-moniker-undefined-redelegations b/changes/mario_2983-moniker-undefined-redelegations
@@ -0,0 +1 @@
+[Fixed] [#2983](https://github.com/cosmos/lunie/issues/2983) Fix undefined validator moniker in redelegations @mariopino
diff --git a/src/components/staking/PageValidator.vue b/src/components/staking/PageValidator.vue
@@ -383,7 +383,7 @@ export default {
           return validators.concat({
             address: address,
             maximum: Math.floor(committedDelegations[address]),
-            key: `${delegate.moniker} - ${formatBech32(
+            key: `${delegate.description.moniker} - ${formatBech32(
               delegate.operator_address,
               false,
               20

diff --git a/tests/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap b/tests/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap
@@ -1286,7 +1286,7 @@ Array [
   },
   Object {
     "address": "cosmosvaladdr15ky9du8a2wlstz6fpx3p4mqpjyrm5ctplpn3au",
-    "key": "undefined - cosmosvaladdr…3p4mqpjyrm5ctplpn3au",
+    "key": "good_greg - cosmosvaladdr…3p4mqpjyrm5ctplpn3au",
     "maximum": 5,
     "value": 1,
   },
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		[Fixed] [#2983](https://github.com/cosmos/lunie/issues/2983) Fix undefined validator moniker in redelegations @mariopino