Merge pull request #411 from cosmos/matt/387-gaia-check

Check Gaia version at runtime

CHANGELOG.md

@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Added a changelog @jolesbi.
 
 ## [0.3.1] - 2018-01-30
+### 
+* Check to ensure gaia version is correct for the current network @mappum
+
 ### Changed
 * Resolved notifications error on NiSessionLoading.vue @nylira.
 * Resolved old saved prevAccountKey being used in NiSessionSignIn.vue @nylira.

app/src/main/index.js

@@ -222,6 +222,14 @@ async function startBaseserver (home, nodeIP) {
   return child
 }
 
+async function getGaiaVersion () {
+  let child = startProcess(SERVER_BINARY, ['version'])
+  let data = await new Promise((resolve) => {
+    child.stdout.on('data', resolve)
+  })
+  return data.toString('utf8').trim()
+}
+
 function exists (path) {
   try {
     fs.accessSync(path)
@@ -323,8 +331,11 @@ if (!TEST) {
   })
 }
 
-function consistentConfigDir (versionPath, genesisPath, configPath) {
-  return exists(genesisPath) && exists(versionPath) && exists(configPath)
+function consistentConfigDir (appVersionPath, genesisPath, configPath, gaiaVersionPath) {
+  return exists(genesisPath) &&
+    exists(appVersionPath) &&
+    exists(configPath) &&
+    exists(gaiaVersionPath)
 }
 
 function pickNode (seeds) {
@@ -374,9 +385,10 @@ async function main () {
     return
   }
 
-  let versionPath = join(root, 'app_version')
+  let appVersionPath = join(root, 'app_version')
   let genesisPath = join(root, 'genesis.json')
   let configPath = join(root, 'config.toml')
+  let gaiaVersionPath = join(root, 'gaiaversion.txt')
 
   let rootExists = exists(root)
   await fs.ensureDir(root)
@@ -389,8 +401,8 @@ async function main () {
 
     // check if the existing data came from a compatible app version
     // if not, backup the data and re-initialize
-    if (consistentConfigDir(versionPath, genesisPath, configPath)) {
-      let existingVersion = fs.readFileSync(versionPath, 'utf8')
+    if (consistentConfigDir(appVersionPath, genesisPath, configPath, gaiaVersionPath)) {
+      let existingVersion = fs.readFileSync(appVersionPath, 'utf8')
       let compatible = semver.diff(existingVersion, pkg.version) !== 'major'
       if (compatible) {
         log('configs are compatible with current app version')
@@ -427,13 +439,22 @@ async function main () {
     fs.accessSync(networkPath) // crash if invalid path
     fs.copySync(networkPath, root)
 
-    fs.writeFileSync(versionPath, pkg.version)
+    fs.writeFileSync(appVersionPath, pkg.version)
   }
 
   log('starting app')
   log(`dev mode: ${DEV}`)
   log(`winURL: ${winURL}`)
 
+  let gaiaVersion = await getGaiaVersion()
+  let expectedGaiaVersion = fs.readFileSync(gaiaVersionPath, 'utf8').trim()
+  log(`gaia version: "${gaiaVersion}", expected: "${expectedGaiaVersion}"`)
+  // TODO: semver check, or exact match?
+  if (gaiaVersion !== expectedGaiaVersion) {
+    throw Error(`Requires gaia ${expectedGaiaVersion}, but got ${gaiaVersion}.
+      Please update your gaia installation or build with a newer binary.`)
+  }
+
   // read chainId from genesis.json
   let genesisText = fs.readFileSync(genesisPath, 'utf8')
   let genesis = JSON.parse(genesisText)

tasks/testnet.js

@@ -31,10 +31,15 @@ async function main () {
     .catch(e => {
       throw new Error(`Can't load config.toml: ${e.message}`)
     })
+    let gaiaVersionTxt = await get(`https://github.com/tendermint/testnets/raw/master/${network}/gaia/gaiaversion.txt`)
+    .catch(e => {
+      throw new Error(`Can't load config.toml: ${e.message}`)
+    })
     let path = join(tmpdir(), Math.random().toString(36).slice(2))
     mkdirp(path)
     write(join(path, 'genesis.json'), genesisJson)
     write(join(path, 'config.toml'), configToml)
+    write(join(path, 'gaiaversion.txt'), gaiaVersionTxt)
     runDev(path)
   }
 }

test/unit/specs/main.spec.js

@@ -10,6 +10,7 @@ jest.mock('fs-extra', () => {
   let mockFs = mockFsExtra()
   mockFs.writeFile('./app/networks/gaia-2/config.toml', fs.readFileSync('./app/networks/gaia-2/config.toml', 'utf8'))
   mockFs.writeFile('./app/networks/gaia-2/genesis.json', fs.readFileSync('./app/networks/gaia-2/genesis.json', 'utf8'))
+  mockFs.writeFile('./app/networks/gaia-2/gaiaversion.txt', fs.readFileSync('./app/networks/gaia-2/gaiaversion.txt', 'utf8'))
   return mockFs
 })
 let fs = require('fs-extra')
@@ -27,6 +28,13 @@ childProcessMock((path, args) => ({
     if (type === 'exit' && args[1] === 'init') {
       cb(0)
     }
+  },
+  stdout: {
+    on: (type, cb) => {
+      if (args[0] === 'version' && type === 'data') {
+        cb({toString: () => 'v0.5.0'})
+      }
+    }
   }
 }))
 
@@ -429,6 +437,13 @@ function failingChildProcess (mockName, mockCmd) {
           cb(0)
         }
       }
+    },
+    stdout: {
+      on: (type, cb) => {
+        if (args[0] === 'version' && type === 'data') {
+          cb({toString: () => 'v0.5.0'})
+        }
+      }
     }
   }))
 }