Skip to content

Commit

Permalink
Merge pull request #324 from cosmos/jordan/notify
Browse files Browse the repository at this point in the history
don't need notify when change is shown in UI
  • Loading branch information
faboweb authored Jan 5, 2018
2 parents 1736afd + d3c5310 commit 1b1b85c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion app/src/renderer/components/common/NiSessionSignIn.vue
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export default {
await this.$store.dispatch('testLogin', { password: this.fields.signInPassword, account: this.fields.signInName })
this.$store.dispatch('signIn', { password: this.fields.signInPassword, account: this.fields.signInName })
this.$store.commit('setModalSession', false)
this.$store.commit('notify', { title: 'Signed In', body: `You are now signed in to your Cosmos account.` })
} catch (err) {
this.$store.commit('notifyError', { title: 'Signing In Failed', body: err.message })
}
Expand Down
2 changes: 0 additions & 2 deletions test/unit/specs/NISessionSignIn.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ describe('NiSessionSignIn', () => {
signInName: 'name'
}})
await wrapper.vm.onSubmit()
let commitCalls = store.commit.mock.calls.map(args => args[0])
expect(commitCalls).toContain('notify')
expect(store.dispatch).toHaveBeenCalledWith('signIn', {
password: '1234567890',
account: 'name'
Expand Down

0 comments on commit 1b1b85c

Please sign in to comment.