Don't patch ASGI and WSGI transports by default #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundberg
force-pushed
the
dont-patch-asgi-wsgi
branch
from
8159fcf to
ce044a5
Compare
lundberg
added a commit
that referenced
this pull request
Apr 27, 2021
Changed - Require `HTTPX` 0.18.0 and implement the new transport API. (PR #142) - Removed ASGI and WSGI transports from httpcore patch list. (PR #131) - Don't pre-read mocked async resposne streams. (PR #136) Fixed - Fixed syntax highlighting in docs, thanks @florimondmanca. (PR #134) - Type check `route.return_value`, thanks @tzing. (PR #133) - Fixed a typo in the docs, thanks @lewoudar. (PR #139) Added - Added support for adding/removing patch targets. (PR #131) - Added test session for python 3.10. (PR #140) - Added RESPX Mock Swallowtail to README. (PR #128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
HTTPXas test client, i.e. testingFastAPI, you'll pass your asgi app to the client.Therefore RESPX shouldn't patch those app transports by default.
This PR removes the asgi and wsgi transports from the default list of patch targets, but also adds support for manually adding and removing transports of your choice, i.e. re-adding any of those or adding a custom 3:rd party transport.
If anyone needs the current behaviour, patching asgi and/or wsgi transports, one now needs to do: