-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafana Dashboard #116
base: main
Are you sure you want to change the base?
Grafana Dashboard #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i run docker compose up
it brings everything up but in Grafana I don't see any data source or dashboards, they should be automatically configured in Grafana but for some reason they're missing.
I removed all containers before running so it's not because of any pre-existing Grafana container.
@@ -83,7 +83,7 @@ SLF4J: See also http://www.slf4j.org/codes.html#replay | |||
man [e] > Scala 2 to Scala 3 > sudoku solver initial state > | |||
``` | |||
|
|||
- Run the Sodukosolver by executing the `runSolver` command from the `sbt` prompt. | |||
- Run the Sudokusolver by executing the `runSolver` command from the `sbt` prompt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -42,11 +43,12 @@ object Main { | |||
object SudokuSolverMain { | |||
|
|||
def main(args: Array[String]): Unit = { | |||
Kamon.init() | |||
|
|||
val system = ActorSystem[NotUsed](Main(), "sudoku-solver-system") | |||
|
|||
println(s"${GREEN}Hit RETURN to stop solver${RESET}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run / fork := true
is required for Kamon instrumentation to work (if the application doesn't run in a forked JVM then the instrumentation agent can't be attached so no metrics are sent anywhere)
BUT, this stops the application blocking on StdIn.readline()
- hence the need to remove the two lines below (otherwise it just falls through to system.terminate()
) - not sure why, seems to be a known thing.
We should remove them completely rather than just commenting out, and probably remove the println
as well as it's not necessary either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove them completely rather than just commenting out, and probably remove the println as well as it's not necessary either.
Yes, please remove it as needed
2af1ff0
to
2cfc044
Compare
85309ba
to
22a913e
Compare
- Removed some graphs that are not relevant to the demo - Changed dashboard layout
No description provided.