Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bareword warn in compat.lua is a "strict" violation #432

Closed
tkoeppe opened this issue Jun 10, 2022 · 0 comments · Fixed by #437
Closed

Bareword warn in compat.lua is a "strict" violation #432

tkoeppe opened this issue Jun 10, 2022 · 0 comments · Fixed by #437

Comments

@tkoeppe
Copy link

tkoeppe commented Jun 10, 2022

The bareword warn in

if not warn then -- luacheck: ignore
is an undefined variable, which some "strictness" checking tools (such as https://github.com/deepmind/strict/) diagnose and reject.

I believe you can achieve the same effect without use of potentially undefined variables by replacing

if not warn then

with:

if not rawget(_G, 'warn') then

Would you perhaps be able to make that change?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant