Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML-Parser: Adding a BUILD to use perl Makefile.pl. #3728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stumbles
Copy link
Member

No description provided.

@lunar-linux-b01
Copy link

SUCCESS!

@dagbrown
Copy link
Member

default_perl_build already uses Makefile.PL though.

https://github.com/lunar-linux/lunar/blob/19816bf6ac99449c06c9478cdb8cc1425b5bae8b/libs/build.lunar#L338-L356

What does this do that that doesn't?

@esselfe
Copy link
Member

esselfe commented Dec 30, 2024

This started with a problem I had when deploying a graphical environment from the ground up to see where the CI build steps would trip, like Ratler said was happening.

The original idea about this approach (not using default_perl_build) was to fix XML-SAX and XML-SAX-Expat on first installs. XML-SAX was throwing an error about missing SAX.pm in the perl path and XML-SAX-Expat was missing XML/SAX/Expat.pm.

This is probably because the default_perl_build function is using a destdir approach. This fix was for those two in moonbase-other though, so I don't really understand the need to change XML-Parser since this one is in core, so it's already installed.

Perhaps some confusion with the current CI always failing because of the missing Parser.pm, idk.

@dagbrown dagbrown added the iso_ok Verified does not break the daily ISO build label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iso_ok Verified does not break the daily ISO build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants