Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify configuration initialization #14

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

lumiasaki
Copy link
Owner

Current situation

Currently, when developers initialize an instance of Configuration for SceneBox, they need to distribute not only states from product aspect, but also unique identifiers for them, which is meaningless for developers, we want developers keep focusing on states from product level, since that this time we simplify the while process for initialization of SceneBox and Configuration.

Changes

Based on conclusions as above, we deleted the process about distribution unique identifiers and bind them with state of scenes. Meanwhile, lazyAdd APIs from SceneBox switched to use scene state rather than identifier.

Further more, we believe the navigationController assignment in Configuration was also a redundant process, due to developers already set navigation controller for the first scene in entry block.

Lastly, in order to organize the setting steps of SceneBox into one place, this time we introduced a new type ConfigurationFile, which can make you to put all your configurations into one place, and be easier to reuse it just like a file, in this ConfigurationFile, you can distribute your scene states and decide which extensions will be enabled for SceneBox.

@lumiasaki lumiasaki added the enhancement New feature or request label Jul 29, 2021
@lumiasaki lumiasaki merged commit e6f19e1 into main Jul 29, 2021
@lumiasaki lumiasaki deleted the feature/simplify_configuration_initialization branch July 29, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant