Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metas.ts): Simplify Twitter Card Tags #488

Merged
merged 2 commits into from Sep 13, 2023
Merged

feat(metas.ts): Simplify Twitter Card Tags #488

merged 2 commits into from Sep 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2023

Description

This commit optimizes the plugin by simplifying the Twitter Card tags (twitter:*) when OpenGraph tags (og:*) are present, eliminating the need for redundant tags.

Changes Made:

  • Removed twitter:title tag when og:title is present.
  • Removed twitter:image tag when og:image is present.
  • Removed twitter:description tag when og:description is present.
  • Simplified Twitter Card tags to include only and when tags are present.

Related Issues

Related to #487

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

This commit optimizes the  plugin by simplifying the Twitter Card tags () when OpenGraph tags () are present, eliminating the need for redundant tags.

Changes Made:
- Removed  tag when  is present.
- Simplified Twitter Card tags to include only  and  when  tags are present.

References:
- Twitter Card Markup Documentation: https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/markup
- Getting Started with Twitter Cards: https://developer.twitter.com/en/docs/twitter-for-websites/cards/guides/getting-started
- Social Media Meta Tags Best Practices: https://head-2ml.pages.dev/#social-media

Closes #487
@oscarotero
Copy link
Member

Thank you!
Can you update the tests, please? (run npm task test:update)

@oscarotero oscarotero merged commit 9739e36 into lumeland:master Sep 13, 2023
3 checks passed
@oscarotero
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant