Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esbuild plugins option does not work #445

Merged
merged 1 commit into from
Jul 7, 2023
Merged

esbuild plugins option does not work #445

merged 1 commit into from
Jul 7, 2023

Conversation

kuboon
Copy link
Contributor

@kuboon kuboon commented Jul 7, 2023 •
edited
Loading

Description

esbuild plugin has lumeLoaderPlugin.
It works at first and catches all.
That means all other appended plugins are actually ignored.

Related Issues

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@kuboon kuboon changed the title esbuild plugins does not work esbuild plugins option does not work Jul 7, 2023
@oscarotero oscarotero merged commit 4504db3 into lumeland:master Jul 7, 2023
3 checks passed
@oscarotero
Copy link
Member

It makes sense. Thanks!

@kuboon kuboon deleted the fix-esbuild-plugin branch July 7, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuboon @oscarotero