-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CLI Commands more independent #34
Make CLI Commands more independent #34
Conversation
- each command exports its own usage info - each command parses its own cli options - cli.js handles the --help and --version requests
Test it out here:
|
Hi, thanks for your work here. Maybe cli.js can export a Then, Another thing: can you run Thanks! |
* handle HELP message without a dynamic import * clean up repetitive code by using an inline function
* create cliUtils file to hold shared functions
1336e46
to
cc27a5c
Compare
Thanks. all, for reviewing. Made various changes to address the feedback:
|
Test out the latest here: https://raw.githubusercontent.com/JordanShurmer/lume/39514dad3dd2f5f5ce92c8aabbbf7eb53735cd8b/cli.js
|
Great job. Thank you @JordanShurmer |
Note: this PR is to the
cli-refactor
branch, not master.What Changed
cli/
are more independent and self-actualizingI Need Help
I'm not sure how to implement the
run
command. This PR adds it as anunimplemented()
piece of code.We could merge this into the
cli-refactor
branch then fix the run command in there, or we can update this PR if someone can assist in implementing it.