Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automatic Type Popup] fix + remove type prefixes #34

Merged
merged 4 commits into from
Nov 15, 2015

Conversation

rvion
Copy link
Collaborator

@rvion rvion commented Nov 2, 2015

related to #26

@tomv564
Copy link
Collaborator

tomv564 commented Nov 4, 2015

I fixed the tests and then turned the region highlighting back on, too. I think it can be merged, unless the plan was to turn the region highlighting off.

@rvion
Copy link
Collaborator Author

rvion commented Nov 4, 2015

thanks you very much !
No, the plan was not to turn the region highlighting off, I just hacked something quickly last time.

Before merging, I also need to fix the shorten_module_prefix function so it works with types like

undefined :: x1 -> (A.B.x2 -> [B.C.x3]) -> x4

For now, the opening parens: '(' and opening bracket: '['sare not properly kept

I'll push the fix tomorrow

@rvion rvion self-assigned this Nov 4, 2015
@rvion
Copy link
Collaborator Author

rvion commented Nov 15, 2015

Automatic type popup on hovering now replace qualified type prefixes by an "_" to help readability.
Hitting Cmd+T still display the type as it was before, so one can still ask the editor where do the types comes from.

It should only affect those using the automatic type popup

example

  • with the show type command/shortcut:
    image
  • with the automatic type popup
    image

rvion added a commit that referenced this pull request Nov 15, 2015
[Automatic Type Popup] fix + remove type prefixes
@rvion rvion merged commit 9b89046 into master Nov 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants