Turn off some features on non-Haskell views, add more tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomv564
added a commit
that referenced
this pull request
Oct 21, 2015
Turn off some features on non-Haskell views, add more tests
|
Was just running into that myself : ). Thanks so much for all this awesome work Tom!! |
|
For a new project this package is pretty compact and complete. Hope the tests help us keep it stable! Time to do do some non-python work :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the listener processes were firing stack-ide requests on yaml, text etc. file types, I filtered them out to avoid some errors.
This also brings test coverage to close to 80%. Some further reconfiguration of imports was needed.
The .travis.yml file describes what is needed to run tests and get coverage (python ~3.3 virtual env, two pip packages). You can also run the tests without the pip packages using
python -m unittestin the project root.