-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint response type with partial parsing #65
base: main
Are you sure you want to change the base?
Conversation
Is there a reason to have |
I don't think there was any particular reason to have two Response classes other than to have |
This looks good to me |
I've got the implementation where it's now easy to upgrade endpoints to Responses. I'm going to integrate it into my app to validate the changes work well before finishing up the work. |
be1f501
to
cad893a
Compare
Initial take on #55 with the
timeline
,status
, andsearch
endpoints updated.New
Response
class that contains instances ofResult
as a singleresult
or multipleresults
which each have amodel
orexception
.One upside of this is the new response objects can start surfacing rate limit details.
One downside is the searchend point is considered having single model response and if any one of them failed to parse none of the other results would be available.
Fixes #55