Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

lsp-test should wait for the lsp server to exit cleanly #70

Closed
pepeiborra opened this issue Jun 9, 2020 · 3 comments
Closed

lsp-test should wait for the lsp server to exit cleanly #70

pepeiborra opened this issue Jun 9, 2020 · 3 comments
Assignees

Comments

@pepeiborra
Copy link
Contributor

Even for well-behaved servers, runSession calls cleanupProcess immediately after sending the exit message:
https://github.com/bubba/lsp-test/blob/master/src/Language/Haskell/LSP/Test/Session.hs#L268-L272

This causes problems in the ghcide benchmark suite, where we are unable to collect the RTS statistics before lsp-test kills ghcide, and are forced to manage our own exit protocol. But this in turn causes problems with lsp-test, as reported in https://github.com/digital-asset/ghcide/issues/617

@lukel97
Copy link
Owner

lukel97 commented Jun 10, 2020

Hi, can you try out lsp-test on master and see if its waiting for ghcide to exit now?

@pepeiborra
Copy link
Contributor Author

Thanks for the quick response! I can confirm it works as expected now.

@lukel97
Copy link
Owner

lukel97 commented Jun 10, 2020

There's a new bug fix release on Hackage now

lukel97 added a commit to haskell/lsp that referenced this issue Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants