Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to parse imports only and an option to pass file contents #4

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Add option to parse imports only and an option to pass file contents #4

merged 2 commits into from
Oct 11, 2016

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Sep 30, 2016 •
edited
Loading

  • Autocomplete feature in VS Code Go extension uses go-outline to get imported packages. Having a "imports-only" option will help in skipping the overhead of parsing the complete file
  • Autocomplete feature in VS Code Go extension also needs to run when the file has changes that is not saved. Therefore, an option to pass the file contents to go-outline would help too

This was referenced Oct 2, 2016
Merged
Merged
@ramya-rao-a ramya-rao-a changed the title Add option to parse imports only Add option to parse imports only and an option to pass file contents Oct 7, 2016
@lukehoban lukehoban merged commit e785568 into lukehoban:master Oct 11, 2016
@lukehoban
Copy link
Owner

Looks good!

@ramya-rao-a ramya-rao-a mentioned this pull request Oct 23, 2016
Merged
@ramya-rao-a ramya-rao-a deleted the imports-only branch April 9, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramya-rao-a @lukehoban