fix: ensure default types cascade to alibi;

- Closes #10
lukeed · Mar 24, 2020 · 5437ea5 · 5437ea5
1 parent 40051e6
commit 5437ea5
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 2 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -46,8 +46,14 @@ module.exports = function (args, opts) {
 
 	if (defaults) {
 		for (k in opts.default) {
-			opts.alias[k] = opts.alias[k] || [];
-			(opts[typeof opts.default[k]] || []).push(k);
+			name = typeof opts.default[k];
+			arr = opts.alias[k] = opts.alias[k] || [];
+			if (opts[name] !== void 0) {
+				opts[name].push(k);
+				for (i=0; i < arr.length; i++) {
+					opts[name].push(arr[i]);
+				}
+			}
 		}
 	}
 

diff --git a/test/index.js b/test/index.js
@@ -93,6 +93,54 @@ test('flag default and alias', t => {
 	t.end();
 });
 
+test('flag default string w/ alias', t => {
+	t.deepEqual(
+		fn(['--arg', '01'], {
+			alias: { a: ['arg'] },
+			default: { arg: '' },
+		}),
+		{ _: [], arg: '01', a: '01' }
+	);
+
+	t.deepEqual(
+		fn(['-a', '01'], {
+			alias: { a: ['arg'] },
+			default: { arg: '' },
+		}),
+		{ _: [], arg: '01', a: '01' }
+	);
+
+	// ---
+
+	t.deepEqual(
+		fn(['-a', '01'], {
+			alias: { arg: ['a'] },
+			default: { a: '' },
+		}),
+		{ _: [], arg: '01', a: '01' }
+	);
+
+	t.deepEqual(
+		fn(['--arg', '01'], {
+			alias: { arg: ['a'] },
+			default: { a: '' },
+		}),
+		{ _: [], arg: '01', a: '01' }
+	);
+
+	// ---
+
+	t.deepEqual(
+		fn(['-a', '01'], {
+			alias: { arg: ['a'] },
+			default: { arg: '' },
+		}),
+		{ _: [], arg: '01', a: '01' }
+	);
+
+	t.end();
+});
+
 // test('newlines in params' , t => {
 //    var args = fn(['-s', "X\nX"])
 //    t.deepEqual(args, { _ : [], s : "X\nX" });