Skip to content

Commit

Permalink
jaeger: Fix storing segments
Browse files Browse the repository at this point in the history
In scionproto#3128 we switched to temp storage, but that is deleted after calling down on the container.
That would mean on CI we can't access the traces, therefore switch back to the old storage approach.

Also update the version in scion.sh
  • Loading branch information
lukedirtwalker committed Sep 10, 2019
1 parent 49267ac commit b875be2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion python/topology/jaeger.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,13 @@ def _generate_dc(self):
],
'environment': [
'SPAN_STORAGE_TYPE=badger',
'BADGER_EPHEMERAL=false',
'BADGER_DIRECTORY_VALUE=/badger/data',
'BADGER_DIRECTORY_KEY=/badger/key',
'BADGER_CONSISTENCY=true',
],
'volumes': [
'%s:/tmp' % self.docker_jaeger_dir,
'%s:/badger:rw' % self.docker_jaeger_dir,
],
}
}
Expand Down
2 changes: 1 addition & 1 deletion scion.sh
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ cmd_traces() {
-e BADGER_CONSISTENCY=true \
-v "$trace_dir:/badger" \
-p "$port":16686 \
jaegertracing/all-in-one:1.12.0
jaegertracing/all-in-one:1.14.0
sleep 3
x-www-browser "http://localhost:$port"
}
Expand Down

0 comments on commit b875be2

Please sign in to comment.