Skip to content

Commit

Permalink
docs: actually all helm hooks are ignored (argoproj#15752)
Browse files Browse the repository at this point in the history
* docs: actually all helm hooks are ignored

Signed-off-by: naruse666 <[email protected]>

* fix: add "All of"

Signed-off-by: naruse666 <[email protected]>

* Update docs/user-guide/helm.md

Co-authored-by: Blake Pettersson <[email protected]>
Signed-off-by: naruse <[email protected]>

---------

Signed-off-by: naruse666 <[email protected]>
Signed-off-by: naruse <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
  • Loading branch information
2 people authored and lukaszgyg committed Jan 12, 2024
1 parent ed0e9af commit 7f64702
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/user-guide/helm.md
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Argo CD supports many (most?) Helm hooks by mapping the Helm annotations onto Ar
Unsupported hooks are ignored. In Argo CD, hooks are created by using `kubectl apply`, rather than `kubectl create`. This means that if the hook is named and already exists, it will not change unless you have annotated it with `before-hook-creation`.

!!! warning "Helm hooks + ArgoCD hooks"
If you define some Argo CD hooks in addition to the Helm ones, the Helm hooks will be ignored.
If you define any Argo CD hooks, _all_ Helm hooks will be ignored.

!!! warning "'install' vs 'upgrade' vs 'sync'"
Argo CD cannot know if it is running a first-time "install" or an "upgrade" - every operation is a "sync'. This means that, by default, apps that have `pre-install` and `pre-upgrade` will have those hooks run at the same time.
Expand Down

0 comments on commit 7f64702

Please sign in to comment.