Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for broken ignore and allow regex #210

Merged
merged 1 commit into from
Nov 27, 2018
Merged

fix for broken ignore and allow regex #210

merged 1 commit into from
Nov 27, 2018

Conversation

slimbuck
Copy link
Contributor

The ignore and allow regex patterns are treated like unix paths. The call to upath.toUnix() converts one or more \ characters to / and completely brakes regex.

This was referenced Oct 20, 2017
@lu8aja
Copy link

lu8aja commented Oct 25, 2017

+1
The change seems to be right.
A few lines above your change, the path being tested is forced to unixstyle, meaning that at the configs you should ALWAYS use unixstyle, thus a windows style \ should never be present, then a \ should always be interpreted as a regex escape instead of a directory separator.

My only suggestion would be to add an explicit note to the help at the allow and ignore descriptions specifying that unix directory separators should always be used, regardless of the OS in use.

@isymbo
Copy link

isymbo commented Jul 4, 2018

when this fix can be merged?

@NajSurf NajSurf merged commit 80c7d13 into lukasz-wronski:master Nov 27, 2018
@NajSurf
Copy link
Collaborator

NajSurf commented Nov 27, 2018

It should be working fine from now on. I'll try to release it today.

@frobinsonj
Copy link

frobinsonj commented Nov 28, 2018

Just a note, any existing paths using '\\' instead of '/' will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants