Pass undefined instead of an empty string

lukasmoellerch · Jun 28, 2020 · b7a153f · b7a153f
1 parent 0b07be4
commit b7a153f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/compiler/preprocess/index.ts b/src/compiler/preprocess/index.ts
@@ -95,7 +95,7 @@ export default async function preprocess(
 		source = await replace_async(
 			source,
 			/<!--[^]*?-->|<script(\s[^]*?)?(?:>([^]*?)<\/script>|\/>)/gi,
-			async (match, attributes = '', content = '') => {
+			async (match, attributes = '', content) => {
 				if (!attributes && !content) {
 					return match;
 				}
@@ -115,7 +115,7 @@ export default async function preprocess(
 		source = await replace_async(
 			source,
 			/<!--[^]*?-->|<style(\s[^]*?)?(?:>([^]*?)<\/style>|\/>)/gi,
-			async (match, attributes = '', content = '') => {
+			async (match, attributes = '', content) => {
 				if (!attributes && !content) {
 					return match;
 				}

diff --git a/test/preprocess/samples/script-self-closing/_config.js b/test/preprocess/samples/script-self-closing/_config.js
@@ -3,7 +3,7 @@ import * as assert from "assert";
 export default {
 	preprocess: {
 		script: ({ content, attributes }) => {
-			assert.equal(content, "");
+			assert.equal(content, undefined);
 			return {
 				code: `console.log("${attributes["the-answer"]}");`
 			};

diff --git a/test/preprocess/samples/style-self-closing/_config.js b/test/preprocess/samples/style-self-closing/_config.js
@@ -3,7 +3,7 @@ import * as assert from "assert";
 export default {
 	preprocess: {
 		style: ({ content, attributes: { color } }) => {
-			assert.equal(content, "");
+			assert.equal(content, undefined);
 			return {
 				code: `div { color: ${color}; }`
 			};