Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Endeavour OS logo #71

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Add Endeavour OS logo #71

merged 2 commits into from
Jun 1, 2022

Conversation

ronan696
Copy link
Contributor

Added support for EndeavourOS, updated preview.png and README.md.

Closes: #70

Copy link
Owner

@lukas-w lukas-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ronan696 and please apologize the long delay. I've had a look at the SVG and noticed that it's slightly wider than the original. Here they are side by side:

image

Would you be able to fix that?

@ronan696
Copy link
Contributor Author

@lukas-w, no issues at all. Thanks for your feedback.

What is the source of the image that you have used for comparison? Seems like it may have been resized as the SVG I've submitted is based on this one.

image

@lukas-w
Copy link
Owner

lukas-w commented May 20, 2022

Well now that's weird. IIRC my source was https://commons.wikimedia.org/wiki/File:EndeavourOS_Logo.svg:

image

However even on endeavouros.com they have different versions of their logo, the first one in this screenshot is more narrow than the other:

image

So now what? 😆

@lukas-w
Copy link
Owner

lukas-w commented May 20, 2022

@killajoe You've been maintaining endeavouros-team/endeavouros-theming so I hope you don't mind me tagging you here. We're working on adding Endeavour OS's logo to this icon font but there appear to be two different versions used on the official website. One is wider than the other as can be seen in the screenshots above. Could you help clarify which is the correct one?

@killajoe
Copy link

@killajoe ...One is wider than the other as can be seen in the screenshots above. Could you help clarify which is the correct one?

Could you link me to the one wider? i am not the creator of the icons/logo but i rmemebr i needed to modify them because they where not square so may i missed one of them?

@killajoe
Copy link

uh thanks i will try fixing it .. should be the narrow versions.

@ronan696
Copy link
Contributor Author

Thanks @killajoe !

@lukas-w, I'll fix the logo over the weekend and push the changes

@ronan696 ronan696 requested a review from lukas-w May 21, 2022 20:13
@ronan696
Copy link
Contributor Author

ronan696 commented May 21, 2022

@lukas-w, I've fixed the SVG to match the narrower logo. Do let me know if it's okay. Thanks!

Copy link
Owner

@lukas-w lukas-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @killajoe for clarifying and @ronan696 for updating the PR 👍

@lukas-w lukas-w merged commit 584a32b into lukas-w:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font request: Endeavour OS
3 participants