-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify some outlines #127
Conversation
[why] The SVG contains groups of paths that were obviously differently colored before resulting in a glyph with very strange outlines. [how] Flatten all path to one path. Simplify the path. Hand-optimize some points and remove others. Double points and very sharp tips. From 511 points to 176. Reported-by: Aaron Bell <@aaronbell> Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
Points unchanged Signed-off-by: Fini Jastrow <[email protected]>
Sorry I did not mean to ping Lukas specifically... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons looks the same, LGTM
Thank you for reviewing :-) |
Did similar things here
Hope most of the really bad things are now fixed. Well, one PR is pending at MaterialDesign, and Codicons also had two broken glyphs. Do you think we should update Codicons? But then a lot icons changed dramatically to some more modern version. Sigh. |
Mmm, seems last update was about 3 years ago, could be that some users are expecting to have the same exact icons as in VSCode. Also the fact that are some "missing" icons (could be instances in other font sets), there are 387 nf-cod-* icons on NF but 457 on https://github.com/microsoft/vscode-codicons/tree/main/src/icons with 35 changes last year. Maybe is worth a discussion on NF. Personally I won't oppose to the change because pretty much all the icons for code that arrive to my terminal it's because I'm using fancy plugins on Neovim & other applications, so the maintainers of such plugins are the ones who really control which icons to use, at the end I'm just a final user that uses whatever arrives from upstream. |
Thanks for your thoughts! 💚
Hmm, that does not look like so many, but I have not counted. And I was mistaken, it was Material that has changed dramatically, the changes in codicons seem all very acceptable and I see no reason to not do it. And all (that means 100%) of the users I talked to (n = 1) said an update would be welcome :-) I think this will go. |
[why]
The SVG contains groups of paths that were obviously differently colored before resulting in a glyph with very strange outlines.
[how]
Flatten all path to one path.
Simplify the path.
Hand-optimize some points and remove others.
Double points and very sharp tips.
From 511 points to 176.
Reported-by: Aaron Bell <@aaronbell>
Current glyph in
font-logos.ttf
:New simplified path:
Old Tux left and optimized Tux right:
Old to new size comparsion (34k -> 5k).