Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The update Kali icon is barely visible #82

Closed
daniruiz opened this issue Jul 7, 2022 · 3 comments
Closed

The update Kali icon is barely visible #82

daniruiz opened this issue Jul 7, 2022 · 3 comments

Comments

@daniruiz
Copy link
Contributor

daniruiz commented Jul 7, 2022

With the latest update the icon for Kali is way too small. I know the previous image was oversized but that was done on purpose, as Kali's logo is really hard to align and too thin.

This is the commit with the changes to the logo:
aef7b01

Here's a comparison of the old and new icons being used in the terminal:
Old:
image
New:
image

The screenshots are taken using zoom in the terminal, so this is how it really looks with the normal terminal font-size:

image

@lukas-w
Copy link
Owner

lukas-w commented Jul 7, 2022

I didn't consider anyone using non-monospace fonts in a terminal, sorry! Simply reverting this will break fixed-width display with .fl-fw. I'll try to come up with something that accommodates both use cases. Also the previous logo extended outside the em square, so I'll scale it back up to 1 em height which is slightly smaller than it used to be but still ~30% larger than the current one in v1.0.0. Hope that works.

@lukas-w
Copy link
Owner

lukas-w commented Jul 8, 2022

Done via 42440ab and released in v1.0.1.

@lukas-w lukas-w closed this as completed Jul 8, 2022
@daniruiz
Copy link
Contributor Author

daniruiz commented Jul 8, 2022

Thank you! 😉

Finii added a commit to ryanoasis/nerd-fonts that referenced this issue Jul 16, 2022
[why]
That release contains a bugfix:
lukas-w/font-logos#82

Signed-off-by: Fini Jastrow <[email protected]>
Finii added a commit to ryanoasis/nerd-fonts that referenced this issue Aug 18, 2022
[why]
That release contains a bugfix:
lukas-w/font-logos#82

Signed-off-by: Fini Jastrow <[email protected]>
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
That release contains a bugfix:
lukas-w/font-logos#82

Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants