Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Krita icon #113

Closed
hasecilu opened this issue Nov 20, 2023 · 16 comments · Fixed by #115
Closed

Problem with Krita icon #113

hasecilu opened this issue Nov 20, 2023 · 16 comments · Fixed by #115

Comments

@hasecilu
Copy link
Collaborator

Krita logo have some artifacts in the header.

image

I generated the header in my machine and it's ok, also checked the font and it's ok too.

image

@hasecilu
Copy link
Collaborator Author

Intersection in the brush:
image

@hasecilu
Copy link
Collaborator Author

Extra nodes (bottom left):
image

@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

And I already pushed to NPM 😬

https://npmfs.com/package/font-logos/

It's also in the font:

image

@hasecilu
Copy link
Collaborator Author

I opened the ttf font from the GitHub release and have the artifact

image

@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

I'm fighting with inkscape right now, am used to work in Glyphs and need to find out how to remove the handle :-D

@hasecilu
Copy link
Collaborator Author

hasecilu commented Nov 20, 2023

I pushed to master an update, let's see if that fixes the problem
Edit: header remains the same

@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

I can fix that, or do you want to fix that, I always am confused.

@hasecilu
Copy link
Collaborator Author

I removed the intersection but that didn't resolve the problem, did you find another problematic node? I'll let you fix it

Finii added a commit that referenced this issue Nov 20, 2023
There are two problematic point-clusters, removed.

Fixes: #113

Signed-off-by: Fini Jastrow <[email protected]>
Finii added a commit that referenced this issue Nov 20, 2023
Fixes: #113

Signed-off-by: Fini Jastrow <[email protected]>
Finii added a commit that referenced this issue Nov 20, 2023
Fixes: #113

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii changed the title Problem with the rendered header from the CI Problem with Krita icon Nov 20, 2023
@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

Are the more bugs or is it time for 1.1.1 ;-)

@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

Fixed problems here, iirc:

image

@hasecilu
Copy link
Collaborator Author

I'm looking at the new logos but still don't find anything odd. If you want to 1.1.1 is ok, (always could be an 1.1.2)

@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

I guess I need to be more thorough...

image
Tip of the brush stroke in the left of the icon

@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

Found more issues ... prepared the new svg

image

@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

Ah the reason that local and workflow differ is that different fontforge versions are used.

image

At least I guess you use (as I do) Fontforge 20230101 ?
In fact I usually use a self-build Fontforge with some patches in.
If you also use a newer version I will change the workflow to use a newer fontforge to prevent unexpected surprises. (Hmm, are there expected surprises? ;-)

Fontforge is two revisions ahead of the default workflow version.
At NerdFont I learned that one always needs to use the latest ff release as there really are bugs fixed.

image

So, please tell me your libfontforge version? (apt show python3-fontforge)

@hasecilu
Copy link
Collaborator Author

hasecilu commented Nov 20, 2023

I use this version that dates from April, maybe I should start using fontforge-git

paru -Qi fontforge                                                                                            
Name            : fontforge
Version         : 20230101-3
Description     : Outline and bitmap font editor
...
Build Date      : 2023年04月07日 00時26分40秒

Finii added a commit that referenced this issue Nov 20, 2023
[why]
The CI uses Ubuntu 22.04 and thus Fontforge 20201107.
That has some bugs that can show.

[how]
Use the latest Fontforge as AppImage instead.

Change the makefile to allow the python library or the fontforge
executable, prefering the later.

[note]
See discussion in #113

Signed-off-by: Fini Jastrow <[email protected]>
@Finii
Copy link
Collaborator

Finii commented Nov 20, 2023

Well, there is no newer release than 2023-01-01, but you use that already.

Now the workflow uses that fontforge. All the workflow snippets are taken from Nerd Fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants