Do not create JsonMap.entries over and over again

lukas-krecan · Jun 26, 2024 · 4023661 · 4023661
1 parent 01d5fc8
commit 4023661
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/json-unit-core/src/main/java/net/javacrumbs/jsonunit/core/internal/Node.java b/json-unit-core/src/main/java/net/javacrumbs/jsonunit/core/internal/Node.java
@@ -222,18 +222,23 @@ interface ValueExtractor {
     class JsonMap extends AbstractMap<String, Object> implements NodeWrapper {
         private final Node wrappedNode;
 
+        private Set<Entry<String, Object>> entrySet;
+
         JsonMap(Node node) {
             wrappedNode = node;
         }
 
         @NotNull
         @Override
         public Set<Entry<String, Object>> entrySet() {
-            Iterator<KeyValue> fields = wrappedNode.fields();
-            return StreamSupport.stream(Spliterators.spliteratorUnknownSize(fields, 0), false)
-                    .map(keyValue -> new SimpleEntry<>(
-                            keyValue.getKey(), keyValue.getValue().getValue()))
-                    .collect(Collectors.toSet());
+            if (entrySet == null) {
+                Iterator<KeyValue> fields = wrappedNode.fields();
+                entrySet = StreamSupport.stream(Spliterators.spliteratorUnknownSize(fields, 0), false)
+                        .map(keyValue -> new SimpleEntry<>(
+                                keyValue.getKey(), keyValue.getValue().getValue()))
+                        .collect(Collectors.toSet());
+            }
+            return entrySet;
         }
 
         @Override