Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deleting properties #23

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

luisherranz
Copy link
Owner

@luisherranz luisherranz commented Jun 21, 2023

What

Add support for deleting properties like delete store.a.

Why

Because it's another type of mutation that can be applied to plain JS objects, so it should be supported.

How

Add the deleteProperty handler.

I branched this PR on top of luisherranz/deepsignal#20, so we should wait until that one is merged to merge this one.

@luisherranz luisherranz requested a review from DAreRodz June 21, 2023 08:32
@luisherranz luisherranz self-assigned this Jun 21, 2023
@luisherranz luisherranz linked an issue Jun 21, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

Size Change: +279 B (+5%) 🔍

Total Size: 5.75 kB

Filename Size Change
packages/deepsignal/core/dist/deepsignal-core.js 939 B +49 B (+6%) 🔍
packages/deepsignal/core/dist/deepsignal-core.mjs 923 B +43 B (+5%) 🔍
packages/deepsignal/dist/deepsignal.js 976 B +46 B (+5%) 🔍
packages/deepsignal/dist/deepsignal.mjs 970 B +47 B (+5%) 🔍
packages/deepsignal/react/dist/deepsignal-react.js 975 B +46 B (+5%) 🔍
packages/deepsignal/react/dist/deepsignal-react.mjs 970 B +48 B (+5%) 🔍

compressed-size-action

@luisherranz luisherranz marked this pull request as ready for review June 21, 2023 08:50
Base automatically changed from dont-reproxy-proxies to main June 21, 2023 13:05
Copy link
Collaborator

@DAreRodz DAreRodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 👍

@luisherranz luisherranz merged commit acc8bd9 into main Jun 21, 2023
@luisherranz luisherranz deleted the support-delete-properties branch June 21, 2023 14:15
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deleting a key does not trigger effects
2 participants