#230 uppercase to add to check signature

luguslabs · Jul 21, 2020 · 9209103 · 9209103
1 parent ec74104
commit 9209103
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/orchestrator/src/routes/sms.js b/orchestrator/src/routes/sms.js
@@ -11,10 +11,9 @@ router.post(
     const params = Object.assign(req.query, req.body);
     console.log('/webhooks/inbound-sms');
     // console.log(params);
-    // console.log('generated sig = ' + Nexmo.generateSignature(orchestrator.nexmoApiSignatureMethod, orchestrator.nexmoApiSignatureSecret, params));
-    // console.log('params.sig = '+ params.sig);
     if (orchestrator.nexmoApiCheckMsgSignature === 'true') {
-      if (Nexmo.generateSignature(orchestrator.nexmoApiSignatureMethod, orchestrator.nexmoApiSignatureSecret, params) === params.sig) {
+      const sigToCheck = Nexmo.generateSignature(orchestrator.nexmoApiSignatureMethod, orchestrator.nexmoApiSignatureSecret, params);
+      if (sigToCheck && sigToCheck.toUpperCase() === params.sig) {
         console.log('Valid signature');
         if (params && params.text && params.text.toString() !== '') {
           console.log('text:' + params.text.toString());
@@ -42,10 +41,9 @@ router.get(
     const params = Object.assign(req.query, req.body);
     console.log('/webhooks/inbound-sms');
     // console.log(params);
-    // console.log('generated sig = ' + Nexmo.generateSignature(orchestrator.nexmoApiSignatureMethod, orchestrator.nexmoApiSignatureSecret, params));
-    // console.log('params.sig = '+ params.sig);
     if (orchestrator.nexmoApiCheckMsgSignature === 'true') {
-      if (Nexmo.generateSignature(orchestrator.nexmoApiSignatureMethod, orchestrator.nexmoApiSignatureSecret, params) === params.sig) {
+      const sigToCheck = Nexmo.generateSignature(orchestrator.nexmoApiSignatureMethod, orchestrator.nexmoApiSignatureSecret, params);
+      if (sigToCheck && sigToCheck.toUpperCase() === params.sig) {
         console.log('Valid signature');
         if (params && params.text && params.text.toString() !== '') {
           console.log('text:' + params.text.toString());