Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a new major version after PR #349 #380

Closed
Asvarox opened this issue Aug 13, 2019 · 5 comments
Closed

Release a new major version after PR #349 #380

Asvarox opened this issue Aug 13, 2019 · 5 comments

Comments

@Asvarox
Copy link

Asvarox commented Aug 13, 2019

Seems like that #349 considerably changed the way to use .env values in iOS build settings/info.plist file. It might be a good idea to release the version of the lib with these changes, as installation instructions in current readme.md won't work for the most recently published NPM package.

@bericp1
Copy link

bericp1 commented Aug 14, 2019

As a stop gap measure, I've installed the specific commit on master right now (89a602bf8be3808838403a97afaf915caeec76c2) directly from GitHub and it's working on both Android and iOS. Tested the Info.plist iOS modifications and those are also working on master.

Obviously installing directly from GitHub isn't recommended but as a temporary measure, anyone who needs these latest changes can run:

yarn add react-native-config@"luggit/react-native-config#89a602bf8be3808838403a97afaf915caeec76c2"

@erwann-miriel-nv
Copy link

It would really help to have a new release. I got stuck for a day trying to solve the "'GeneratedDotEnv.m' file not found" until I installed from github

@Sbphillips19
Copy link

@erwann-miriel-nv add in the script found here- #365

I forgot to do pod install and ended up back here, sure it will happen again with this library.

@MrLoh
Copy link

MrLoh commented Oct 11, 2019

@pedro @jordanbrown @erickreutz can someone please make an npm release or fork this package, what's the point of merging PRs and then not releasing an update?

@pedro
Copy link
Contributor

pedro commented Nov 14, 2019

Oops, sorry for the delay folks, 0.12 has been released with #349.
For updates on repo ownership and updates follow #382.
Thanks!

@pedro pedro closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants