-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo ownership & maintenance status – migrating to react-native-community or a new owner #382
Comments
I'm also looking for that problem.
|
I am getting the whole app frozen and button press does not work at all in one of the screen after using this library, need any kind of alternate, I am thinking to create a custom Native bridge anyway |
Have you followed the instructions in this issue? #365 |
Im on RN 0.60.5 and using |
Check this article for an alternative https://medium.com/commutatus/multi-environment-variable-setup-for-react-native-application-70fde4de657f |
Considering the popularity and wide adoption, this project should be migrated to https://github.com/react-native-community |
I think this library has been effectively abandoned. Any charitative souls willing to maintain a fork? |
@atulmy I can facilitate making that happen, but the issue is that it seems that the maintainers are not responding to DMs or messages or pings in any way. If they want to reach out to me directly so that we can make this happen, pls DM me on twitter. |
Funny you should say that, I've opened this project: https://github.com/x-react-native/env-config Would dearly love some help to get it into shape so I can publish a new npm module asap! |
any updates regarding moving this repo to |
@melodydrewvr thanks for the update 🎉, let me know if you need help in maintaining it :) |
@melodydrewvr - any progress? I was thinking of forking and fixing it for us, but if this is going to move to react-native-community I would love to help with that. @melodydrewvr - if you want let's connect and sync our efforts on this. |
👋 folks - I've asked to the community owners and basically the conversation is about understanding the "overlap" between this lib and the I've proposed a gradual roadmap that would lead to the two converging, as soon as I have a "final say" of some sort from their side I'll update @melodydrewvr & y'all - hopefully it won't be long. |
The overlap between |
hey folks! so sorry we dropped the ball here – I'm no longer working at Lugg and they are super busy with other stuff, but we'd all love to work with the community to find a new home and maintainers for this project. @melodydrewvr @kelset let us know how can we help with the move to react-native-community! I like how Thanks, |
I am using
so it was a no brainer to say no to I'm using my vars in JS, Gradle, Objective-C, Java, XML and Info.plist. The only issue I haven't been able to address is that in Circle CI builds Info.plist vars are always empty so I had to address that by manually entering the needed values for particular schemes as user settings and then refer to that var in the Info.plist file, which is not such a big deal but regardless, it would be awesome to have all configs in just one file. No doubt this module is very powerful and it works but; most of the pain comes from the confusing documentation on Github and npmjs. Can we at least correct that first? Pretty sure there won't be as much of an outcry from the community if the documentaion is not confusing them in the first place. |
Hi everyone, I'm going to be out of contact for about a week so apologies in advance for not being able to progress the fork until I'm available again. However, if there are any pull requests you'd like to see merged please feel free to raise them in the meantime. In particular, any documentation changes that @JanithaR has mentioned would be a great starting point. I've also gone through the PRs raised against this repo that I'd like to see merged too, so hopefully when I'm free again next week we'll be in a better position to get a new package published (one way or another!) |
sounds good, yeah I haven't been following but if anyone can point me to important PR's to merge here I'll give it a try and merge/publish it - at least to stop the bleeding! |
It's weekend for me and I'm with my kid and wife fulltime. I'll extend my help first thing Monday. |
@pedro how about as step 0 you just migrate this repo to @melodydrewvr (of give him admin rights to the repo & the publishing ones too)? I'll link this conversation back into the discord. |
Definitely, added! I'll just add a mention of Lugg to the readme, but up to you guys where to take it from here 👌 |
Hi all, do we have an ETA for this move to react-native-community? |
@pedro could you publish a new version of this library so we can use while waiting for the migration? |
👋 folks - @melodydrewvr was on holiday last week, so it will take a bit longer before this lib will get back on its feet, but a bit of patience will go a long way.
No ETA no this for the foreseeable future, if there are updates on that we will keep you updated :) |
@leethree oh doh! yes just pushed v0.12.0. |
What was included in the v0.12.0 release? There are no notes attached... Is is basically a release of the master branch of this repo, i.e. what was previously:
Or were any PRs or changes included? Thanks! |
@kelset, can we expect to see this package move to https://github.com/react-native-community soon? @pedro has already given a go ahead to do so in this comment. May the force be strong with React Native! |
no updates on my side, there was some pushback when I asked internally 😓 I'll try to ask again |
Hi @kelset someone brought this up to me. Not sure the reasoning for the push back, but I wouldn't mind helping maintain the repo when in community. |
That would be me. Thanks in advance on behalf of everyone using react-native-config and godspeed. :D |
Hey everyone, I tried to raise this again in the internal Discord but I'm sorry to report that - basically - until this conversation (react-native-community/discussions-and-proposals#176) has reached a final say, there should be no expectation of this repo being moved in the RNCommunity. What I would recommend for the time being is that the repo & npm rights are given directly to one of the new maintainers. |
Who are the new maintainers now? @mvrdrew - I don't see a fork under your account? |
I think a lot of interest in updating maintainers died out when a new npm release with the auto-linking included, as that was the biggest blocker a lot of people seemed to have. I did make a fork under a different account with the intention of getting it into shape for RNC, but after some discussions with @kelset about whether it'd be accepted I lost a bit of momentum. The fork is here: https://github.com/x-react-native/env-config |
@mvrdrew So what are we going to do? I haven't used the library in an year and I'm looking at it for another project. There are 37 pull requests - which doesn't really give me the confidence that it works. With react-native-community refusing to accept such packages it leaves us at a very unfortunate place. We either have to create a b-league as @kelset put it in the discussion on the react-native-community issues or just fork ourselves. I'm against forking myself and adding the pull-requests I'm interested in as this create a disconnected ecosystem. Nobody knows what is current and what not. |
just to clarify folks - I don't think that forking is the solution, but migrating this repo to another user so that it has an active maintainer with all the permissions (both github and npm). I don't know if @pedro has the correct rights to do so since IIRC admin rights are needed. |
@erickreutz @pedro Can you help us to migrate to another user that maintain this repo? or give the role (access to commit and publish this package) for someone to volunteer to maintain this repo (I'm one). Who else volunteers? like this comment to @erickreutz and @pedro (or any repo owner) so they know who the volunteers are |
for sure! it's unfortunate that the move to react-native-community got stuck, but happy to give you access so we can keep things going! 👍 just did it, let me know if anything. What's your npm handle? I can give you permissions to release it too. |
@pedro thanks! my npm https://www.npmjs.com/~luancurti and npm email [email protected] |
You're the man! Really amazing how you already got to all that stuff! I'm getting this error trying to add you to the project, any ideas?
Can't seem to do it via the web either 🤔 |
@pedro first you need add me as a maintainer after this you can add me as a owner follow this steps https://docs.npmjs.com/transferring-a-package-from-a-user-account-to-another-user-account |
Odd, from the command line it really doesn't work, but after disabling adblock I could see the admin tab and add you from the web – lemme know if it's all good now! I'll let you decide on newer versions/etc, fwiw we were doing semver and enjoying the flexibilities of major version 0 heh. Feel free to go for 1.0 obv, whatever makes sense! |
It worked! Thanks!
Of course, thanks again! |
Repo is back in business I see. ;) |
Hey, I created alternative config library react-native-ultimate-config. It supports all features of In addition many issues that have been opened recently in react-native-config do not exist in my lib (well, at least as far as I could test them): #449 , #446 , #438 , #432 , #426, #443, #442, #413 and others of that sort. |
@maxkomarychev if you would like to help us to fix this issues. Will be a great help and the community will be very grateful |
Glad to see progress here! Seeing that things should go smoother now, @maxkomarychev if you forked from this one it'd be awesome if you pushed new features here. Many, many people are already using this lib including myself. It makes more sense to me for it to be here. |
@luancurti may be worth closing this issue, with you writing a last comment saying how the repo is now again under proper maintenance and leave some way of contacting / reaching out to you if they want to help you maintain it; then lock the issue so that it will be the last comment. On top of that, echoing what both @luancurti and @lesmo said, @maxkomarychev I would suggest that you join forces and push your work back into this main repo and help by becoming a maintainer of it 🤗 ofc this is OSS so if you prefer to go your own way with the fork noone can blame you for that 🤗 |
Hi, I created That said I'd be happy to help the community. Of course I am biased to my lib but perhaps you would consider a scenario where my lib supersedes |
to complement my previous answer: if superseding scenario is not an option and you prefer to keep existing ruby scripts and other things I'd still be happy to share my views on design and why I did what I did in my library |
Thanks to all for the discussion in this issue. I'll close this because we find a new maintainer and we are looking to help to maintain this package them feel free to open pull requests in this repository |
After going through tons of issues and trying every possible way to get this awful messy repo to work, I tried to work with this "https://github.com/luggit/react-native-config.git#89a602b" and the npm version, it just won't work, does anyone have have a stable fork that i can use ?
i'm using react-native 0.60.5
The text was updated successfully, but these errors were encountered: