-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant checks whereever possible #47
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 89.94% 89.77% -0.18%
==========================================
Files 3 3
Lines 358 352 -6
==========================================
- Hits 322 316 -6
Misses 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am all in favor of simpler code, removing redundancy. I haven't tested this one.
FWIW I tested your 3.1.0 now on master, and the tests and examples are all good on my julia 1.7 linux laptop. Thanks for that! Alex |
Sure, no reason not to simplify. Seems to be a merge conflict at the moment though |
Good point, I will work on the conflicts later today |
Merging stale PR |
Take care of #46 .