Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant checks whereever possible #47

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

jkrimmer
Copy link
Contributor

@jkrimmer jkrimmer commented Sep 1, 2022

Take care of #46 .

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (d987944) to head (24e280e).
Report is 4 commits behind head on master.

Current head 24e280e differs from pull request most recent head a73b437

Please upload reports for the commit a73b437 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   89.94%   89.77%   -0.18%     
==========================================
  Files           3        3              
  Lines         358      352       -6     
==========================================
- Hits          322      316       -6     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ahbarnett ahbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am all in favor of simpler code, removing redundancy. I haven't tested this one.

@ahbarnett
Copy link
Collaborator

FWIW I tested your 3.1.0 now on master, and the tests and examples are all good on my julia 1.7 linux laptop. Thanks for that! Alex

@ludvigak
Copy link
Owner

ludvigak commented Sep 2, 2022

Sure, no reason not to simplify. Seems to be a merge conflict at the moment though

@jkrimmer
Copy link
Contributor Author

jkrimmer commented Sep 2, 2022

Good point, I will work on the conflicts later today

@ludvigak ludvigak marked this pull request as ready for review June 25, 2024 09:16
@ludvigak
Copy link
Owner

Merging stale PR

@ludvigak ludvigak merged commit d9a1e6a into ludvigak:master Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants