Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep references to input arrays in guru plan struct #40

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Conversation

ludvigak
Copy link
Owner

This should hopefully avoid segfault due to users not knowing exactly how the memory management works under the hood.

Fixes #39

@ludvigak ludvigak self-assigned this Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #40 (4568f59) into master (f935efa) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   89.70%   90.05%   +0.35%     
==========================================
  Files           3        3              
  Lines         340      352      +12     
==========================================
+ Hits          305      317      +12     
  Misses         35       35              
Impacted Files Coverage Δ
src/guru.jl 86.99% <100.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f935efa...4568f59. Read the comment docs.

@ludvigak ludvigak assigned ludvigak and unassigned ludvigak Feb 16, 2022
@tknopp
Copy link

tknopp commented Feb 16, 2022

Just tested this branch and can confirm, this fixes #39!

Copy link
Collaborator

@ahbarnett ahbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, haven't tested locally! Notice to fix "now" -> "know" in one of the comments. Thanks, Alex

@ludvigak ludvigak merged commit d7214b8 into master Feb 17, 2022
@ludvigak ludvigak deleted the setpts_ref branch February 17, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple plans simultaneously
3 participants