Handle secondary rate limit in device activation (#264)

ludeeus · Dec 10, 2023 · b885481 · b885481
1 parent 1c5d4d3
commit b885481
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/aiogithubapi/device.py b/aiogithubapi/device.py
@@ -21,7 +21,7 @@
     GitHubRequestKwarg,
     HttpMethod,
 )
-from .exceptions import GitHubException
+from .exceptions import GitHubAuthenticationException, GitHubException
 from .legacy.device import AIOGitHubAPIDeviceLogin as LegacyAIOGitHubAPIDeviceLogin
 from .models.base import GitHubBase
 from .models.device_login import GitHubLoginDeviceModel
@@ -151,6 +151,14 @@ async def activation(
                 },
             )
 
+            if (
+                isinstance(response.data, str)
+                and "You have exceeded a secondary rate limit" in response.data
+            ):
+                raise GitHubAuthenticationException(
+                    "Secondary rate limit exceeded, try again in 1 hour"
+                )
+
             if error := response.data.get("error"):
                 self.logger.debug(response.data.get("error_description"))
                 if error in (DeviceFlowError.AUTHORIZATION_PENDING, DeviceFlowError.SLOW_DOWN):

diff --git a/tests/device/test_device_flow.py b/tests/device/test_device_flow.py
@@ -2,6 +2,7 @@
 # pylint: disable=missing-docstring,protected-access
 from datetime import datetime
 from unittest.mock import AsyncMock
+from aiogithubapi.exceptions import GitHubAuthenticationException
 
 import pytest
 
@@ -124,3 +125,13 @@ async def test_error_while_waiting(
     mock_response.mock_data = {"error": "any", "error_description": "Any error message"}
     with pytest.raises(GitHubException, match="Any error message"):
         await github_device_api.activation(device_code=DEVICE_CODE)
+
+
+@pytest.mark.asyncio
+async def test_secondary_rate_limit(
+    github_device_api: GitHubDeviceAPI,
+    mock_response: MockResponse,
+):
+    mock_response.mock_data = "<html><p>You have exceeded a secondary rate limit.<br></html>"
+    with pytest.raises(GitHubAuthenticationException, match="Secondary rate limit exceeded"):
+        await github_device_api.activation(device_code=DEVICE_CODE)