Fix warnings reported by shellcheck #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the
shellcheckhas not been run on the action runner itself. There was a common error with iteration over find results with a simple for-loop. Such loop does not handle correctly file names with spaces. This PR fixes that issue. However, I had to join two steps ("Gather base file paths" and "Run the file check") into one. GitHub does not support passing array variable between steps, and passing gathered files in a simple string will not work for file names with spaces. To prevent mistakes like that in the future, I've added a test file with a whitespace in the name.