Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointer types #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pointer types #17

wants to merge 1 commit into from

Conversation

OverlordQ
Copy link

Removes the warnings, dont quote me on the properness of this fix, passes all tests. Fixes #16

@coveralls
Copy link

coveralls commented Oct 6, 2016

Coverage Status

Coverage remained the same at 94.373% when pulling 5cc924b on OverlordQ:develop into f5e4552 on ludbb:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.373% when pulling 5cc924b on OverlordQ:develop into f5e4552 on ludbb:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.373% when pulling 5cc924b on OverlordQ:develop into f5e4552 on ludbb:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.373% when pulling 5cc924b on OverlordQ:develop into f5e4552 on ludbb:master.

@OverlordQ
Copy link
Author

Failing test failed in Jenkins setup, not actual test-suite

@mcelrath
Copy link

Could we get this one merged? This warning message is driving me nuts. I've tested this patch and it works.

@ofek
Copy link

ofek commented Mar 22, 2017

@ludbb Any thoughts?

ofek added a commit to ofek/coincurve that referenced this pull request Mar 28, 2017
@ofek
Copy link

ofek commented Mar 28, 2017

This is fixed in my fork https://github.com/ofek/coincurve

@bartzy
Copy link

bartzy commented Aug 26, 2017

Will this PR be merged soon?

Thanks!

@ofek
Copy link

ofek commented Aug 26, 2017

@ztane
Copy link

ztane commented Sep 7, 2017

This seems a proper fix here. There are still other cases of char there that I think should be unsigned too.

@ofek
Copy link

ofek commented Sep 7, 2017

@ztane Which?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings w/ cffi 1.8.3
6 participants