src: remove erroneous default argument in RadixTree

This default argument can never benefit any potential caller because any call site that occurs after this definition will result in a compiler error due to RadixTree::Lookup(const std::string_view&) now being an ambiguous call target. PR-URL: nodejs#50736 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
lucshi · Nov 27, 2023 · 4831f25 · 4831f25
1 parent cbdf5a6
commit 4831f25
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -172,7 +172,7 @@ FSPermission::RadixTree::~RadixTree() {
 }
 
 bool FSPermission::RadixTree::Lookup(const std::string_view& s,
-                                     bool when_empty_return = false) const {
+                                     bool when_empty_return) const {
   FSPermission::RadixTree::Node* current_node = root_node_;
   if (current_node->children.size() == 0) {
     return when_empty_return;