Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of be_on_page in Flow guides #1344

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Remove mention of be_on_page in Flow guides #1344

merged 2 commits into from
Jul 21, 2024

Conversation

jwoertink
Copy link
Member

@jwoertink jwoertink commented Jul 21, 2024

Fixes #1286
Fixes #1075

Also related: luckyframework/lucky_flow#150

Since this method was removed, it no longer makes much sense writing your spec assertions inside of the spec file since you'd have to do stuff like self.should have_element which reads very weird.

@jwoertink jwoertink merged commit 1455842 into main Jul 21, 2024
1 of 2 checks passed
@jwoertink jwoertink deleted the guides/1286 branch July 21, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing HTML and Interactivity mentions be_on_page Update LuckyFlow guides
1 participant