Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added overload to distance_of_time_in_words for Time::Span. #1860

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Added overload to distance_of_time_in_words for Time::Span. #1860

merged 1 commit into from
Mar 30, 2024

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1859

Description

This PR allows you to use the distance_of_time_in_words helper method with a single Time::Span.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit c493598 into main Mar 30, 2024
5 checks passed
@jwoertink jwoertink deleted the issues/1859 branch March 30, 2024 16:02
@jwoertink jwoertink mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add distance_of_time_in_words that takes a Time::Span
1 participant
@jwoertink