Adding new Event to track when a request is complete #1601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ref: luckyframework/breeze#33
Description
This PR adds in a new Pulsar event that will allow Breeze to subscribe and get the request duration. I've also refactored the LogHandler a little to clean up some of the logic with skipping logging.
With that, the time that was logged before included the time it took to print to the logs that a request was starting. That time is irrelevant though. By moving that up, we can just use
Time.measure
which will measure how long it takes to run the rest of the middleware stack. In a future PR, I'll be adding in a unique request ID that will be tracked in here so we can join the before/after loggingChecklist
crystal tool format spec src
./script/setup
./script/test