Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design issue on longer routes #19

Open
jwoertink opened this issue Mar 12, 2021 · 1 comment · Fixed by #54
Open

Design issue on longer routes #19

jwoertink opened this issue Mar 12, 2021 · 1 comment · Fixed by #54

Comments

@jwoertink
Copy link
Member

Some routes can get super long. We need to account for those. Maybe just truncate it after a certain length?

Screen Shot 2021-03-12 at 1 52 11 PM

@jwoertink
Copy link
Member Author

This is still an issue if your route has a ton of query params. We have this method in Lucky url_without_query_params https://github.com/luckyframework/lucky/blob/1f28e05534a046dff4e76bc9a789f522269aab78/src/lucky/routable.cr#L251 what might be good here is a new path_without_query_params method.

span req.path, class: "font-bold"

We can either build one manually and update later after Lucky gets that method, or wait for Lucky to get it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant