Skip to content

Commit

Permalink
Testing Windows PG Patch (#1071)
Browse files Browse the repository at this point in the history
* These are all ignored because they come from the Lucky development dependency

* testing windows CI with new PG patch

* let's see what the error trace says on this

* Using new patches in override

* bump PG to latest for windows fix.
  • Loading branch information
jwoertink authored Nov 9, 2024
1 parent b04ba2d commit 849a747
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 10 deletions.
14 changes: 6 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,11 @@ jobs:
experimental:
- false
include:
# NOTE: PG shard does not compile on Windows https://github.com/will/crystal-pg/issues/291
# Until that's resolved, this will always fail, so leaving this commented out for now
# - shard_file: shard.yml
# crystal_version: latest
# postgres_version: 16
# experimental: true
# os: windows-latest
- os: windows-latest
shard_file: shard.yml
crystal_version: latest
postgres_version: 16
experimental: true
- shard_file: shard.edge.yml
crystal_version: latest
postgres_version: 14
Expand Down Expand Up @@ -89,7 +87,7 @@ jobs:
env:
DATABASE_URL: postgres://lucky:developer@localhost:5432/avram_dev
- name: Run tests
run: crystal spec
run: crystal spec --error-trace
env:
BACKUP_DATABASE_URL: postgres://lucky:developer@localhost:5432/sample_backup
DATABASE_URL: postgres://lucky:developer@localhost:5432/avram_dev
9 changes: 9 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
/lib/
/bin/ameba
/bin/ameba.cr
/bin/lucky.exec.cr
/bin/lucky.watch.cr
/bin/lucky.gen.action.cr
/bin/lucky.gen.action.browser.cr
/bin/lucky.gen.action.api.cr
/bin/lucky.gen.page.cr
/bin/lucky.gen.component.cr
/bin/lucky.gen.task.cr
/bin/lucky.gen.secret_key.cr
/.shards/
/tmp
/config/*.local.cr
Expand Down
5 changes: 3 additions & 2 deletions shard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies:
version: ~> 0.3.0
pg:
github: will/crystal-pg
version: ~> 0.28.0
version: ~> 0.29.0
habitat:
github: luckyframework/habitat
version: ~> 0.4.9
Expand Down Expand Up @@ -49,4 +49,5 @@ development_dependencies:
version: ~> 1.5.0
lucky:
github: luckyframework/lucky
version: ">= 1.0.0"
branch: main
# version: ">= 1.0.0"

0 comments on commit 849a747

Please sign in to comment.