Upgrade rules_jvm_external #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also increases the bazel version. This also bumps the version of rules_nodejs. It is still very out of date, but I wanted to keep the scope of the changes small, and the previous version didn't work on current versions of bazel.
Which also involves upgrading rules_sass and rules_nodejs
|
ugh, I finally got it to work on bazel 6, but now it is broken on bazel 5. What should I do here? |
tmccombs
force-pushed
the
jvm-external-ugprade
branch
from
4509f40 to
5d3fad7
Compare
So that stuff actually works
Switch to using rules_pkg instead of the deprecated built in pkg_tar
|
ok, after going down a rabbit hole of updlating other stuff too, this is finally passed the build. |
jnowjack-lucidchart
approved these changes
Sep 20, 2023
jjudd
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also increases the bazel version.
This also bumps the version of rules_nodejs. It is still very out of date, but I wanted to keep the scope of the changes small, and the previous version didn't work on current versions of bazel.